Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: (4 comments) File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/6b08e191_1d2e6... PS1, Line 247: type record of charstring StrList;
You may be probably reusing this for something no VTY related? then maybe move it to another module […] oh wait, this patch isn't even using this
File library/PFCP_CodecPort_CtrlFunct.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/08125310_038b1... PS1, Line 7: inout PFCP_PT portRef,
did you copy this? indentation looks weird. yes, i most definitely copied it, because i would not have had a clue how to structure a new kind of port. maybe from MGCP or RSL, don't remember which exactly.
i guess it would be an idea to fix the whitespace... at first i was just happy that it worked at all File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/805c91e5_37e53... PS1, Line 18: type enumerated e_PFCP_Cause {
You could move some of these into PFCP_Types. […] i put them directly above the template using them, because that's the only place using it. makes sense to move it to *Types.ttcn as soon as it is a more generally useful type, but for now can stay here, agree?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/ca8feda7_4d035... PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {
Please improve the scope of template types. […] the thing that annoys me there is that universal-ctags in general does a good job of taging ttcn3, but fails to tag functions with such (value) or (present) directives. so i can easily navigate the code as long as those things are not there, as soon as it says '(value)' i have to start grepping manually and copy paste file paths and line numbers. that's my personal motivation to keep those keywords away for as long as i can.
And also I do not notice any functional/semantic difference at all! i don't understand why those directives should be added, how does it help, what is the point i am missing? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 14:00:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment