Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email )
Change subject: gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43468/comment/0a0c65fd_2989d3e5?usp... :
PS8, Line 1418: /* MS identity */
this is already 2 lines above?
I'd welcome if you addressed all the comments before pushing a new version to gerrit. Otherwise please push in a separate personal branch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Icc83186da4fa562bac716c3c7f4448ab46439c3c
Gerrit-Change-Number: 43468
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 09 Sep 2026 18:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de