Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email )
Change subject: trxcon/trx_if: migrate to libosmo-trx ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/e67bedaf_c10c523f?us... : PS1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't
This will enable the feature for some people who happen to have libosmo-trx-dev installed, and not […]
I'm fine with either "yes" or "no", but "auto" should be removed or at least not be the default one. This was already discussed some time ago, and despite other projects may have decided otherwise, we concluded it was better to have a reproducible default independent of installed libraries in a system.
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/8b619239_4661f5e4?us... : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);
Actually, the comment is inaccurate (it predates the final state of libosmo-trx) and the API actuall […]
If the API takes care, why then sending it explicitly here?