19 Aug
2024
19 Aug
'24
11:14 a.m.
Attention is currently required from: neels.
pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email )
Change subject: pfcp_tool: add 'date' ......................................................................
Patch Set 4:
(1 comment)
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/37761/comment/73f3f978_877e0163?usp=... : PS4, Line 144: osmo_gettimeofday(&tv, NULL); This is affected by wall clock system changes. IMHO you should at least provide an option to print CLOCK_MONOTONIC instead (I actually thik this should always be CLOCK_MONOTONIC). The user can then subtract 2 values to get the execution time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I0486cc92ea298bb9926a0e5c26da17ba5970a72c
Gerrit-Change-Number: 37761
Gerrit-PatchSet: 4
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 19 Aug 2024 09:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No