Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email )
Change subject: nokia: add support for Flexi Multiradio ......................................................................
Patch Set 1:
(5 comments)
File src/osmo-bsc/bts_nokia_site.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6aa80188_f56f2265?usp=... : PS1, Line 1778: It is also possible to configure the BTS without a reset, but in this case please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/76114543_09306349?usp=... : PS1, Line 1779: the BTS does not accept any changes in configuration - therefore, the mode please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/5226232d_01ed4c2c?usp=... : PS1, Line 1780: of skipping BSC-driven BTS reset is only for use during osmo-bsc development, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/ad8c4bc5_4326cee1?usp=... : PS1, Line 1781: when the developer-operator resets the BTS manually before each test run. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/fd3a38ef_a59f616f?usp=... : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, Avoid multiple line dereference - prefer 'run.static'