Attention is currently required from: lynxis lazus, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email ) Change subject: Also track downtime when OML link is lost ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35566/comment/2bb98965_0121496b PS1, Line 763: static void ipaccess_sign_link_down(struct e1inp_line *line)
Looks like you probably want to add the downtime count here instead of ipaccess_drop_oml()? What if […] ipaccess_sign_link_down() calls ipaccess_drop_oml() in any case. ipaccess_sign_link_down() acquires the BTS pointer from the link that went down.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1776099cbfef51af1d5a3a056fb0654abd7366a9 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 15 Jan 2024 11:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment