pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 ) Change subject: gmm: Avoid submitting GMMSM-Release.ind if no session was requested ...................................................................... gmm: Avoid submitting GMMSM-Release.ind if no session was requested Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 --- M src/gmm/gmm_ms_fsm.c M tests/gmm/gmm_prim_test.ok 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index ff26dfa..770ede7 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -97,8 +97,9 @@ gprs_gmm_gmme_t3312_stop(ctx->gmme); gprs_gmm_gmme_t3316_stop(ctx->gmme); - /* TS 24.007 9.5.1.4: informs SM layerthat the MS has been GPRS detached, e.g. by timer expiry */ - if (prev_state != GPRS_GMM_MS_ST_NULL) + /* TS 24.007 9.5.1.4: informs SM layer that the MS has been GPRS detached, e.g. by timer expiry */ + if (prev_state != GPRS_GMM_MS_ST_NULL && + ctx->gmme->sess_id != GPRS_GMM_SESS_ID_UNASSIGNED) gprs_gmm_submit_gmmsm_release_ind(ctx->gmme); } diff --git a/tests/gmm/gmm_prim_test.ok b/tests/gmm/gmm_prim_test.ok index 2ff27f6..6cf672a 100644 --- a/tests/gmm/gmm_prim_test.ok +++ b/tests/gmm/gmm_prim_test.ok @@ -23,7 +23,6 @@ test_gmm_prim_llc_down_cb(): Rx LL-UNITDATA.request TLLI=0xec999002 SAPI=GMM l3=[08 05 20 0a 00 05 f4 ec 99 90 02 ] test_gmm_prim_llc_down_cb(): Rx LLGMM-ASSIGN.request old_TLLI=0xec999002 new_TLLI=0xffffffff test_gmm_prim_up_cb(): Rx GMMREG-DETACH.confirm detach_type='GPRS detach' -test_gmm_prim_up_cb(): Rx GMMSM-RELEASE.indication sess_id=4294967295 ==== test_gmm_prim_ms_gmmreg() [end] ==== ==== test_gmm_prim_ms_gmmsm() [start] ==== sys={0.000000}, mono={0.000000}: clock_override_set -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 Gerrit-Change-Number: 33113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged