Attention is currently required from: lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43510?usp=email ) Change subject: libvlr: auth_fsm: split off fsm creation and start of it ...................................................................... Patch Set 1: (1 comment) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/43510/comment/78ab8a3b_c0a645b9?usp=... : PS1, Line 1003: * auth_fsm is assigned an already free'ed fsm */ I think the important thing to state here is (which is not clear in your text): vsub->auth_fsm may be NULL (freed) after the auth_fsm_start() call. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibad920676d9d4a8b7de4a820196385738764ffe9 Gerrit-Change-Number: 43510 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 02 Sep 2026 14:06:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No