lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43131?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: firmware: sniffer: honor the ep argument of usb_msg_alloc_hdr() ...................................................................... firmware: sniffer: honor the ep argument of usb_msg_alloc_hdr() Even though all callers pass the same endpoint anyway the arg should be used and not discarded. Change-Id: I1fa0097b9eef531900b359c7293a6c60040254e4 --- M firmware/libcommon/source/sniffer.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 98cc6cd..93a66b2 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -239,14 +239,14 @@ static struct msgb *usb_msg_alloc_hdr(uint8_t ep, uint8_t msg_class, uint8_t msg_type) { /* Only allocate message if not too many are already in the queue */ - struct llist_head *head = usb_get_queue(SIMTRACE_USB_EP_CARD_DATAIN); + struct llist_head *head = usb_get_queue(ep); if (!head) { return NULL; } if (llist_count(head) > 5) { return NULL; } - struct msgb *usb_msg = usb_buf_alloc(SIMTRACE_USB_EP_CARD_DATAIN); + struct msgb *usb_msg = usb_buf_alloc(ep); if (!usb_msg) { return NULL; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1fa0097b9eef531900b359c7293a6c60040254e4 Gerrit-Change-Number: 43131 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>