Attention is currently required from: osmith, msuraev. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 29: (1 comment) File include/osmocom/smpp/smpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-msc-lint-366): https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/74040fc7_5c2f0534 PS29, Line 58: #define OSMO_FD_CHECK_READ(rc, err_label) do { \ Macros with flow control statements should be avoided -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 29 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: msuraev <msuraev@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 13:49:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment