Attention is currently required from: laforge, pespin, fixeria, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: lint: annotate lines in gerrit ...................................................................... Patch Set 2: (2 comments) File lint/checkpatch/checkpatch_json.py: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/0b3473cb_b0a9c0e2 PS1, Line 3: # from coreboot rev 9cae17d028d4bd3b278fc89ada8e06287917e213
I'd note the exact commit in the commit message, but not in the file. […] Done
File lint/lint_diff.sh: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/1336d844_247fdcf6 PS1, Line 34: if ! git diff -U0 "$COMMIT" | "$SCRIPT_DIR/checkpatch/checkpatch_osmo.sh" > gerrit_report ; then
This condition doesn't need to check if errors were found or not, because above it does "exit 0" if […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Gerrit-MessageType: comment