Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31743 to look at the new patch set (#3). Change subject: tweak MNCC logging, add RTP info ...................................................................... tweak MNCC logging, add RTP info Omit "in state FOO", because LOG_TRANS() already logs the state. Most MNCC "rx" logging was duplicated. Log "rx" only once. If there is RTP information passed with the MNCC message, log it: - if there is SDP, log the SDP information. - if there is no SDP, log the legacy MNCC RTP fields, if any. One motivation to do this is to get RTP information in ladder diagrams generated by msc_log_to_ladder.py without the need to add udtrace MNCC logging to osmo-msc; and also to get RTP info for internal MNCC, where udtrace doesn't apply, because no unix domain socket is involved in internal MNCC operation. Change-Id: I4b916cb482ed441b508c6295de211a21c49cd5c1 --- M src/libmsc/gsm_04_08_cc.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 96 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/31743/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4b916cb482ed441b508c6295de211a21c49cd5c1 Gerrit-Change-Number: 31743 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: newpatchset