12 Aug
2026
12 Aug
'26
9:43 p.m.
Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change by n0k0. ( https://gerrit.osmocom.org/c/libasn1c/+/42890?usp=email )
Change subject: constr_CHOICE: fix always-true bounds check ......................................................................
Patch Set 3:
(1 comment)
File src/constr_CHOICE.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libasn1c/+/42890/comment/ea0e9686_e12a78cf?usp=... : PS3, Line 460: if(present > 0 && present <= td->elements_count) { space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/libasn1c/+/42890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: I25e414729f314505bce50bd8107d61bb1e3a44bf
Gerrit-Change-Number: 42890
Gerrit-PatchSet: 3
Gerrit-Owner: n0k0 osmocom@hacky.software
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: Jenkins Builder
Gerrit-CC: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Wed, 12 Aug 2026 11:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No