Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ......................................................................
Patch Set 13:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/50af2c7f_9167f601?usp=... : PS13, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/cef744e3_929fdb44?usp=... : PS13, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ca4b6089_df896ea2?usp=... : PS13, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/708ca7cc_52e73852?usp=... : PS13, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2df0e11d_3abab7ef?usp=... : PS13, Line 271: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3f2312e8_cd8255d2?usp=... : PS13, Line 272: @param chan channel number please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/072637b2_405a1539?usp=... : PS13, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/963dbe30_b593e0d8?usp=... : PS13, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fa3ce151_d2a503ba?usp=... : PS13, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/46122e20_0bc9d26d?usp=... : PS13, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/162668db_7e780ab5?usp=... : PS13, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line