pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33822 ) Change subject: ASCI: Check return code of osmo_mobile_identity_decode() ...................................................................... ASCI: Check return code of osmo_mobile_identity_decode() Fixes: CID#322146 Change-Id: I15a6cf97a901cbb6c99ec2269051a351b504d338 --- M src/libmsc/ran_msg_a.c 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index 2533045..d2ab09f 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -976,7 +976,8 @@ /* Mobile Identity, 3.2.2.41 */ if (ie_mi) { - if (osmo_mobile_identity_decode(&r->mi, ie_mi->val, ie_mi->len, false)) { + rc = osmo_mobile_identity_decode(&r->mi, ie_mi->val, ie_mi->len, false); + if (rc < 0) { LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Decoding Mobile Identity gave rc=%d\n", rc); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15a6cf97a901cbb6c99ec2269051a351b504d338 Gerrit-Change-Number: 33822 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged