Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549?usp=email ) Change subject: xua asp block: SGP/IPSP: Answer ASPAC with Err if blocked ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549/comment/1941ae5c_531a22... : PS3, Line 733: ss7_asp_set_blocked(asp, false); Don't you need to check `asp->cfg.proto` and `asp->cfg.role` here, like you do above? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I23851fe05c06b6bf59b902632029a2382231427e Gerrit-Change-Number: 42549 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes