Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 8: (4 comments) Patchset: PS6:
none of the comments from April adressed even in January of the following year. I apologize if they have they been marked as resolved in error.
I assume you are stating these facts in order to make me feel supported and to assist in resolving a long standing blockage that has manifested not entirely without your involvement, and which i do not particularly enjoy, at all, for many many months now. Or do you dislike when a branch is submitted to probe build status? File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/41a057b9_9d0ab5b3?usp=ema... : PS3, Line 33: abstract
I think the code has moved but the question remains. […] plug here the same conclusion i formed about the other is_abstract flag. I think we should have one static list, or no list at all in order to make callers have their own static list.
https://gerrit.osmocom.org/c/pysim/+/40096/comment/beaada05_43381e9f?usp=ema... : PS3, Line 132: RandomDigitSource
IMHO it's a bit unintuitive that the IncDigit inherits from RandomDigit. […] ack
https://gerrit.osmocom.org/c/pysim/+/40096/comment/7011df78_b8e47521?usp=ema... : PS3, Line 133: 'incrementing sequence of digits'
cosmetic: the docstring here uses single-quotes, below for the method it uses double-quotes. […] (i never got over it, python used to be so single-quote-y, but at some point linters started making me use double quotes, now my usage ends up completely chaotic, a mix of remembering and forgetting. i mean, you need SHIFT for double quotes...!)
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sun, 11 Jan 2026 04:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>