osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42719?usp=email )
Change subject: lint/checkpatch: ignore MULTILINE_DEREFERENCE ......................................................................
lint/checkpatch: ignore MULTILINE_DEREFERENCE
This linting rule gives false positives, e.g. for this snippet:
static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, uint8_t *l3_msg, unsigned l3_msg_len)
It complains with: src/osmo-bsc/bts_nokia_site.c:1785: WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'run.static'
Related: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/fd3a38ef_a59f616f/ Change-Id: If2a1972fe333f51d534a924fd5ac1c1f7eb65b01 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/42719/1
diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index de14044..c1624e3 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -71,6 +71,7 @@ # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here # * MACRO_WITH_FLOW_CONTROL: not followed # * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars +# * MULTILINE_DEREFERENCE: false positives # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...') @@ -110,6 +111,7 @@ --ignore LONG_LINE_STRING \ --ignore MACRO_WITH_FLOW_CONTROL \ --ignore MISSING_SPACE \ + --ignore MULTILINE_DEREFERENCE \ --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \ --ignore PREFER_FALLTHROUGH \ --ignore REPEATED_WORD \