Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email )
Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ......................................................................
Patch Set 3:
(5 comments)
File src/ss7_as_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/d8484ea1_cee729... : PS3, Line 266: DEFUN_USRATTR(as_tcap_unroutable_route_fallback, as_tcap_unroutable_route_fallback_cmd, It probably make much more sense to have a VTY cmd "tcap-unroutable-sessions route-fallback DPC" instead of extending the previous one and then adding a new extra config which only applies when the former is set.
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/6e40f49b_5be06b... : PS3, Line 470: if (as->cfg.loadshare.tcap.unroutable_tcap_fallback_dpc == 0) this is imho incorrect. 0 is a valid DPC afaiu. Maybe add OSMO_ASSERT(as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) if you want instead.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/7f194af7_215a01... : PS3, Line 474: new_mtp.opc = orig_mtp->opc; this line is a noop, cam be dropped.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/750090c0_c998c5... : PS3, Line 487: * \return 0 on success and asp is set, < 0 on error, > 0 when message is routed elsewhere I see you are updating the return signature here, but I see no modficiation on any code using the function. As so, is it really needed to make the function more complex?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/db1bd9c0_d2501f... : PS3, Line 508: /* Message is handled and will be routed else where */ elsewhere