Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... power_control: lchan_ms_pwr_ctrl(): always log input values Depending on the power control interval (P_Con_INTERVAL), the MS power loop may delay the power control decision for a certain amount of SACCH block periods. In this case lchan_ms_pwr_ctrl() returns early and no logging is printed at all. Let's always log the input values (reported level, UL measurements) early in lchan_ms_pwr_ctrl(). This is useful for debugging, and this is exactly what lchan_bs_pwr_ctrl() does. Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 --- M src/common/power_control.c M tests/power/ms_power_loop_test.err 2 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/42061/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de>