Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/34607/comment/982bafcc_6face1f8 PS1, Line 1279: char strbuf[512]; can be moved to the scope of `if` below, but not critical https://gerrit.osmocom.org/c/libosmocore/+/34607/comment/0e0fffde_5ecedcff PS1, Line 1355: strbuf same here -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7d643c2a0c53f479bfd0d5c36d08c0c01953 Gerrit-Change-Number: 34607 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Oct 2023 16:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment