Attention is currently required from: laforge, neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email )
Change subject: personalization: indicate default ParamSource per ConfigurableParameter
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40200/comment/b9412245_b3d4ba17?usp=ema... :
PS9, Line 362: default_source = param_source.IncDigitSource
the luhn is added implicitly, the editable part is without the luhn. […]
Ah ok. I probably get it. Before everything ends up in the eSIM profile it runs through vaidate_val anyway. And this ensures that the luhn is always present.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40200?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32
Gerrit-Change-Number: 40200
Gerrit-PatchSet: 11
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Wed, 25 Mar 2026 15:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
