Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... libosmo-trx/ep: flush pending TRXC messages on endpoint teardown osmo_trx_ep_close() used to drop any still-queued ctrl socket Tx data via osmo_iofd_free(), including a 'goodbye' TRXC message (i.e. "CMD POWEROFF") that may have just been enqueued right before teardown. Detach such a ctrl_iofd from the endpoint (which may be freed right after osmo_trx_ep_close() returns) and let it live on its own, driven by the same event loop, until the pending write(s) complete (or fail), at which point it closes and frees itself. Data sockets and pending Tx data batches are still dropped immediately, as before. This follows the async-flush pattern used by osmo-pcap's osmo_pcap_wr_file_flush(), adapted to the osmo_io API (there is no osmo_iofd_flush()). Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 --- M libosmo-trx/src/trx_ep.c 1 file changed, 46 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/12/43112/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>