Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... Patch Set 2: Verified+1 (1 comment) File drivers/dahdi/xpp/xbus-core.c: https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/916feaab_7e5543a8?u... : PS1, Line 116: if (xbus->label) {
And if for whatever reason that's not the case, looks like the origianl intention was precisely that […] You are right, and I misunderstood the message from gcc. It was complaining about xbus->label, not *(xbus->label). I've adjusted it now and verified that it builds.
-- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:54:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de>