Attention is currently required from: lynxis lazus.
dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/43196?usp=email )
Change subject: pySim-trace: ignore all other exception and retry parsing it
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
This patch should be ok, it also passes the tests.
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/43196/comment/65f4a867_d1f2840d?usp=ema... :
PS1, Line 7: retry
it's not really a retry of parsing the current APDU, but it's a normal continue with the next APDU w […]
Maybe just write "... and resume parsing"
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/43196?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd
Gerrit-Change-Number: 43196
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 08 Oct 2026 12:08:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org