dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796 ) Change subject: overview.adoc: update network diagram ...................................................................... Patch Set 10: (3 comments) https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796/1/doc/manuals/chapters/overv... File doc/manuals/chapters/overview.adoc: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796/1/doc/manuals/chapters/overv... PS1, Line 29: | | | | | |
Maybe use "MGW (HNB-GW)" and "MGW (MSC)" in there, as suggested in older version of the patch. Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796/1/doc/manuals/chapters/overv... PS1, Line 31: \___________________________________/
You can probably move the "GTP-U" label here instead of having it twice. Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796/8/doc/manuals/chapters/overv... File doc/manuals/chapters/overview.adoc: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796/8/doc/manuals/chapters/overv... PS8, Line 28: | \-->| MGW |<----IuUP--->| MGW | |
I wrote several times that it would be great to have "MGW (BSC)" and "MGW (MSC)" in here, specally s […] I did not see the comment. I have updated it now. I hope its better now.
-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ica1782a407f6b944aa26748b54055168f5d250c3 Gerrit-Change-Number: 26796 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jan 2022 13:15:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment