Attention is currently required from: fixeria, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email ) Change subject: diameter_swx: Fix MAA and SAA parsing mixed ...................................................................... Patch Set 1: (1 comment) File src/epdg_diameter_swx.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783/comment/e59ecda8_b6e92... PS1, Line 205:
It's a usual practice to have no NL between different variants of the same function, so no need to a […] Yeah but given those are potentially long, one for each different message type, I think it makes sense to add it here.
-- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I570dd7c0ae521ccaea5fceb7eef90b4975cb0fbc Gerrit-Change-Number: 34783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator@gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <axilirator@gmail.com> Gerrit-Comment-Date: Wed, 18 Oct 2023 10:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment