Attention is currently required from: daniel, lynxis lazus, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file ......................................................................
Patch Set 5:
(4 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/a6fb0acc_80562939?usp... : PS5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); Use %d instead of %i
File src/sgsn/gprs_gmm_util.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/d035f4b6_8f5d1808?usp... : PS5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg)))) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/7d362860_9b81523e?usp... : PS5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/66c821b5_5987922c?usp... : PS5, Line 115: if (ret < 0) { braces {} are not necessary for single statement blocks