Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... Patch Set 1: (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/f9aca4d2_09a2d... : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout
Why are you removing the loop transition? I think I already explained somewhere that the `state_time […] Yes, that sounded weird to me at the time when you said so. I recall you said that, but that's not the behavior I was seeing when running the ttcn3 tests last week (easily reproducible). I can tell you the timeout is triggering with "keep_state". Furtermore, reading the documentation clearly stated that using "keep_state" is a shortener for "next_state, <current_state>".
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/42305c6f_ac616... : PS1, Line 181: timeout
How do you know that it's specifically a timeout? well, in hear clearly the error is not a timeout, but some error with reason=Reason. So yes, I can maybe better return "{error, Reason}" here.
-- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 22:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>