Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support ......................................................................
Patch Set 9:
(8 comments)
File src/ss7_asp.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/6792dac9_f05060... : PS7, Line 141: struct ss7_qos_class *qos;
Done
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/49652e51_9c5bd9... : PS7, Line 438: "Specify QoS Class of ASP\n"
Why changing this comment? It looks good as-is.
Done
File src/ss7_qos_class.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/9be60ddf_9c9284... : PS7, Line 32: pointer to Application Server
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/bebe2edd_6cd2ef... : PS7, Line 50: pointer to Application Server
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/82f7cc4a_b5fdeb... : PS7, Line 96: pointer to Application Server
Done
File src/ss7_qos_class_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b5aa525b_13f0a1... : PS7, Line 100: CMD_ATTR_NODE_EXIT
Are you sure it's not IMMEDIATE? I don't see any node exit actions here.
Done
File src/ss7_xua_srv.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/d0a672b3_df0c93... : PS7, Line 30: struct ss7_qos_class *qos;
Done
File src/ss7_xua_srv_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/aa5b0de6_3827fd... : PS7, Line 185: CMD_ATTR_NODE_EXIT
Likewise, isn't it IMMEDIATE?
Done