Attention is currently required from: laforge, lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/ffa714f8_d59fb1... : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp)
I implemented it differently. […] My point is that, different to as_del_asp, which clearly defines a relation between an AS and ASP, the ASP going down is non-related to a given AS. Hence I think it makes sense that when an ASP goes down, you first tear down all the relevant specific state at TCAP level for that ASP, then continue with the general path tearing down stuff at the usual M3UA/SUA/IPA level.
I won't block this if others are fine with it, but I still believe the other approach is better from maintenance point of view. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 17 Nov 2026 18:04:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>