[M] Change in pysim[master]: bip: refuse OPEN CHANNEL with a TERMINAL RESPONSE

Attention is currently required from: Hoernchen.

dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43563?usp=email )

Change subject: bip: refuse OPEN CHANNEL with a TERMINAL RESPONSE ......................................................................

Patch Set 2: Code-Review+2

(2 comments)

Patchset:

PS2: From what I can see, the logic looks reasonable and there are also comprehensive unit-tests. I think this patch should be ok.

File tests/unittests/test_bip_relay.py:

https://gerrit.osmocom.org/c/pysim/+/43563/comment/c3fc41c4_b46fa9f6?usp=ema... : PS2, Line 304: 'requested_uicc_if_transp_level_not_available') I am not sure if this is needed or not, but you currently only test with udp_uicc_client_remote, what about testing with the other variants (tcp_uicc_server, udp_uicc_client_local, tcp_uicc_client_local)? Its clear that those will yield the same result (I have read the code), but maybe it makes sense to test those as well?