Attention is currently required from: hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/8bae84d9_553f291f?usp=ema... : PS1, Line 1156: I would argue an integer representation oft the counter would make more sense as a high-level decode compared to a raw byte sequenece. So I'd parse the bytes into an int on decode and re-encode into bytes on encode. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Comment-Date: Fri, 30 Oct 2026 10:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No