Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )
Change subject: tests: improve test infrastructure to support multiple test vectors ......................................................................
Patch Set 1:
(2 comments)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/f86ef24d_e929... : PS1, Line 51: printf("Decoding testvector no %i - %s\n", i, testvectors[i].name); Use %d instead of %i
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/3af280d9_e17b... : PS1, Line 54: if (rc.code != RC_OK) { braces {} are not necessary for any arm of this statement