jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33826 ) Change subject: ASCI: Fix Null pointer dereference bug in gsm44068_bcc_gcc_trans_free() ...................................................................... ASCI: Fix Null pointer dereference bug in gsm44068_bcc_gcc_trans_free() Fixes: CID#322142 Change-Id: Iab0b66dfcfdb870eaec4611720ce3a5f2089bd21 --- M src/libmsc/msc_vgcs.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/33826/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index ca1fa97..3970308 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -1531,12 +1531,11 @@ { struct vgcs_bss *bss, *bss2; - /* Change state. */ - osmo_fsm_inst_state_chg(trans->gcc.fi, VGCS_GCC_ST_N0_NULL, 0, 0); - /* Free FSM. */ - if (trans->gcc.fi) + if (trans->gcc.fi) { + osmo_fsm_inst_state_chg(trans->gcc.fi, VGCS_GCC_ST_N0_NULL, 0, 0); osmo_fsm_inst_term(trans->gcc.fi, OSMO_FSM_TERM_REGULAR, NULL); + } /* Remove relations to cells. * We must loop safe, because bss_clear() will detach every call control instance from list. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iab0b66dfcfdb870eaec4611720ce3a5f2089bd21 Gerrit-Change-Number: 33826 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-MessageType: newchange