Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: proc_indirect_prfle_dwnld: refactor module, fix spec references ......................................................................
proc_indirect_prfle_dwnld: refactor module, fix spec references
The Indirect Profile Download Procedure uses incorrect spec references. As it seems it was a bit mixed up with the Direct Profile Download Procedure, which is very similar, but not identical.
With this patch we: - Move the steps from proc_prfle_dwnld.c into proc_indirect_prfle_dwnld.c - restructure the code - Fix the incorrect spec references - Refactor the error handling (session cancellation) - Add TODOs for parts that are still missing
Related: SYS#8101
Change-Id: I69571280c7b52f2cb09f733bc0466cb77c0d2590 --- M src/ipa/libipa/CMakeLists.txt M src/ipa/libipa/proc_cmn_mtl_auth.c M src/ipa/libipa/proc_indirect_prfle_dwnld.c D src/ipa/libipa/proc_prfle_dwnld.c D src/ipa/libipa/proc_prfle_dwnld.h 5 files changed, 64 insertions(+), 122 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/38/43438/3