Attention is currently required from: dexter, osmith. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email ) Change subject: contrib/sample_ssl_certs: add scripts to generate SSL certificates ...................................................................... Patch Set 2: (60 comments) File contrib/sample_ssl_certs/ca_brainpool/pki/certs_by_serial/4387F5724569508A183B85385B97629A.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/15d3c066_9fc6c042?... : PS2, Line 23: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/bed27173_9b1f6755?... : PS2, Line 25: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/1583ed9c_797ec87b?... : PS2, Line 27: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/375c1de4_34ab6db4?... : PS2, Line 31: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/0740e52f_492fc749?... : PS2, Line 33: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/9a8a36ff_ad6db1c8?... : PS2, Line 35: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/ca_brainpool/pki/inline/private/sample_ssl_cert_brainpool.inline: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/9aa2cf9e_e29b6449?... : PS2, Line 31: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/b751addf_823f9916?... : PS2, Line 33: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/45c784da_d6322dbd?... : PS2, Line 35: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/163eee87_6aa31fe2?... : PS2, Line 39: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/f667732e_75f5a281?... : PS2, Line 41: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/fdd0a08f_93b7468d?... : PS2, Line 43: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/ca_brainpool/pki/issued/sample_ssl_cert_brainpool.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/582fadb0_b4a77730?... : PS2, Line 23: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/7464c269_02945c04?... : PS2, Line 25: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/aa0ff0fd_9b73de3b?... : PS2, Line 27: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/50c96eaf_509d896b?... : PS2, Line 31: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/10df3951_b2fc788a?... : PS2, Line 33: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/0d3b771d_49a414f2?... : PS2, Line 35: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/ca_nist/pki/certs_by_serial/5D16EDAD8E7DBD066792F185C0CC3E9B.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/967b8eaa_b6a1025d?... : PS2, Line 24: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/70d58804_72d9cf4b?... : PS2, Line 26: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/735c4318_d014baa0?... : PS2, Line 28: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/f990183a_62621554?... : PS2, Line 32: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/ba6b7f6c_f71e87dc?... : PS2, Line 34: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/10615afa_9916ce63?... : PS2, Line 36: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/ca_nist/pki/inline/private/sample_ssl_cert_nist.inline: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/3180ac5b_42fcea5e?... : PS2, Line 32: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/ee27c8f9_3b7c9006?... : PS2, Line 34: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/02cad590_3724e9da?... : PS2, Line 36: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/69cc383b_606d4e27?... : PS2, Line 40: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/7ac67ac7_58dfdf2a?... : PS2, Line 42: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/44724374_05e537d2?... : PS2, Line 44: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/ca_nist/pki/issued/sample_ssl_cert_nist.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/f6ab5015_c2d486f3?... : PS2, Line 24: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/101da74f_629e4961?... : PS2, Line 26: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/342f2582_9023aa25?... : PS2, Line 28: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/cfccb735_9fa4ea43?... : PS2, Line 32: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/d7361a4d_964eb260?... : PS2, Line 34: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/3b517924_fd574c72?... : PS2, Line 36: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/sample_ssl_cert_brainpool.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/40a5f093_25ecebeb?... : PS2, Line 23: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/97b9ad82_5ebd673f?... : PS2, Line 25: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/aa46a53b_00a4e240?... : PS2, Line 27: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/81d32b9f_c138d06a?... : PS2, Line 31: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/01ce5f23_91f4f71d?... : PS2, Line 33: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/5f0d9ee0_071abce1?... : PS2, Line 35: X509v3 Subject Alternative Name: trailing whitespace File contrib/sample_ssl_certs/sample_ssl_cert_nist.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/3d5628fc_ff723f55?... : PS2, Line 24: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/b1ddcc47_128abd81?... : PS2, Line 26: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/1f2f11e2_bdea4b7a?... : PS2, Line 28: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/4ef17409_e8f59635?... : PS2, Line 32: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/fdc03a23_30740364?... : PS2, Line 34: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/b27d091d_5500a80f?... : PS2, Line 36: X509v3 Subject Alternative Name: trailing whitespace File priv/sample_ssl_cert_brainpool.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/5a6c1a76_778cd193?... : PS2, Line 23: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/a955c9f6_257b691c?... : PS2, Line 25: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/9f26f538_f2a1b671?... : PS2, Line 27: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/03ff1cb4_486c9143?... : PS2, Line 31: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/2563f0ca_de963378?... : PS2, Line 33: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/2af5b87c_2a02f9da?... : PS2, Line 35: X509v3 Subject Alternative Name: trailing whitespace File priv/sample_ssl_cert_nist.crt: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/74885edd_b3121d79?... : PS2, Line 24: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/3c2d02b2_e157a27c?... : PS2, Line 26: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/3de8947a_612002ec?... : PS2, Line 28: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/51f71ec5_84cad87e?... : PS2, Line 32: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/2b615110_907014e4?... : PS2, Line 34: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/44033/comment/b29ccfc7_f555336c?... : PS2, Line 36: X509v3 Subject Alternative Name: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie75293e5177ccacc45e11d85ef526159e999b7bb Gerrit-Change-Number: 44033 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 05 Nov 2026 16:26:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No