Attention is currently required from: falconia, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32740 )
Change subject: gsm620: make osmo_hr_check_sid compatible with RFC 5993
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/32740/comment/e685a4c8_4ef0857b
PS1, Line 7: gsm630: make osmo_hr_check_sid compatible with RFC 5993
I assume you meant gsm620 here.
Done
Patchset:
PS1:
@fixeria - I concur. […]
I was thinking about normalizing the to one format at the beginning but I quickly realized that this would mean that we would often end up with two unnecessary conversions. This is something I wanted to avoid.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32740
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25728299b757fbc87dd1b3f5adaec9b8b240c5d1
Gerrit-Change-Number: 32740
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia
falcon@freecalypso.org
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 23 May 2023 07:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
