8 Sep
2026
8 Sep
'26
5:53 p.m.
Attention is currently required from: Andrei G.
pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43575?usp=email )
Change subject: core/socket: sockaddr_cmp: compare fields ......................................................................
Patch Set 3:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/43575/comment/e63cb72e_a10c23d1?u... : PS3, Line 357: sockaddr_cmp_sockaddr_cmp_test_SOURCES = sockaddr_cmp/sockaddr_cmp_test.c Please rather add a "sockaddr_test" file instead of "sockaddr_cmp_test" one, and put the sockaddr_cmp() tests in one specific function inside that file.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43575?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I75fc62a92f546a906dbb1440984d62f962579255
Gerrit-Change-Number: 43575
Gerrit-PatchSet: 3
Gerrit-Owner: Andrei G andrei.gosman@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: Andrei G andrei.gosman@gmail.com
Gerrit-Comment-Date: Tue, 08 Sep 2026 15:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No