Attention is currently required from: neels. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342 ) Change subject: After RX of an SMPP Submit, send the SMS we just received. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:
is this essentially bypassing the SMS queue? Each incoming SMS gets sent immediately? […] I would not use the term "bypass".
If the immediate attempt to send were to fail then the fallback would be to the normal sms queue mechanism. Yes, it's a strange beast. It's been a few months since I thought about all this, but IIRC, these patches were a result of attempts to refactor the SMS queue to do things, 1) stop it from consuming ENORMOUS amounts of CPU and blocking osmo-msc and 2) Make delivery of both newly submitted and existing queued SMS reliable according to the destination ME availability. But, there is a pending removal of SMS queue from osmo-msc which makes these patches unnecessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 21:36:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment