Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 2: (4 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/6ef8a812_408cd... PS2, Line 987: ass_compl_chosen_codec "the one" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/fa8d2da6_4af78... PS2, Line 995: re_ass_compl_chosen_codec "the other" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/6d626557_de397... PS2, Line 1723: cpars.re_ass_compl_chosen_codec
Now that this argument is part of the `cpars`, is there still a need to pass it separately, given th […] yes, there are two different phases where _handle_assignment_request happens. *The one* is for the actual normal Assignment, *the other* is for the expected re-assignment if the test feeds in SDP that informs of MT codecs mismatch. That is actually the single main reason to have separated the __handle_assignment_request() function apart from below altstep.
(the src line of this comment shows "the other".) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/3db793b7_a2a16... PS2, Line 1730: ass_compl_chosen_co "the one" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 01:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment