lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email )
Change subject: gprs_gmm: Service Request: add FIXME to check authentication ......................................................................
gprs_gmm: Service Request: add FIXME to check authentication
Before parsing the PDP status of an Service Request, the Service Request has to be authenticated, otherwise it is possible to close a UEs PDP context by sending a fake Service Request.
Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/43598/1
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index c9d5401..c8b2671 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1946,6 +1946,7 @@ /* TODO: Use tlvp_val16le when available */ uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));
+ /* FIXME: this should be done after the connection has been authenticated! */ process_ms_ctx_status(ctx, pdp_status);
/* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not