14 Aug
2023
14 Aug
'23
1:01 p.m.
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34113 )
Change subject: socket: Add osmo_sock_init flag to enable SCTP ASCONF features ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/34113/comment/4dba1b53_d44e5dcf PS2, Line 709: skip
I don't see much of a difference there tbh, I can change it if it looks better to you.
agreed that "skipping" looks better
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iac07031927b66a9d32d2bb2faab817e4c922a359
Gerrit-Change-Number: 34113
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 14 Aug 2023 11:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment