Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33237 ) Change subject: osmo_sccp_simple_client_on_ss7_id(): Always follow VTY config of ASP if it was explicitly defined in VTY ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This may break some existing config file (those which has ASP named "asp asp-clnt-*" defined without explicitly setting them to role=asp & sctp-role=client). However, I deem this necessary since the previous state of things is totally confusing, where one value or the other is taken by default based on implementation details, which also ends up creating trouble to the user/dev. This change (always following same defaults) will also help if we want to ever get out of osmo_sccp_simple_client_on_ss7_id() in osmo-msc, osmo-bsc and osmo-hnbgw. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie81987265118e48173211f88b27a006115dc62d4 Gerrit-Change-Number: 33237 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 17:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment