Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43133?usp=email )
Change subject: host: simtrace2_api: do not log random memory ......................................................................
host: simtrace2_api: do not log random memory
tx_cfg->features is logged before the memcpy() that fills it. Looks like no one is using config.ac --enable-sanitize?
Change-Id: Id8369d312c8600ba9eea80c8f7782f196d7e20d1 --- M host/lib/simtrace2_api.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/33/43133/1
diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c index 37be08a..e2bad31 100644 --- a/host/lib/simtrace2_api.c +++ b/host/lib/simtrace2_api.c @@ -280,7 +280,7 @@
tx_cfg = (struct cardemu_usb_msg_config *) msgb_put(msg, sizeof(*tx_cfg));
- LOGSLOT(ci->slot, LOGL_NOTICE, "<= %s(features=%08x)\n", __func__, tx_cfg->features); + LOGSLOT(ci->slot, LOGL_NOTICE, "<= %s(features=%08x)\n", __func__, user_cfg->features); memcpy(tx_cfg, user_cfg, sizeof(*tx_cfg)); osmo_store32le(user_cfg->features, &tx_cfg->features);