Attention is currently required from: laforge, lynxis lazus, neels.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email )
Change subject: libvlr: auth: never re-use auth tuples for authentication ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/c643aa30_5a992b5c?usp=... : PS1, Line 9: The auth tuples should only ever sent once over the air for authentication. ever be sent
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/1920b864_115c3dfc?usp=... : PS1, Line 11: be re-used other the air for authentication. over the air
File src/libvlr/vlr_auth_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/69bba615_d4c093f6?usp=... : PS1, Line 126: struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, 0); id we always pass zero here, why having the param at all?
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/74cc0ce0_cbe9f0c9?usp=... : PS1, Line 135: int max_reuse_count) this should be removed then too?