Attention is currently required from: biocape.
laforge has posted comments on this change by biocape. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email )
Change subject: Add GSM 7-bit packing and Network Name IE support
......................................................................
Patch Set 1:
(1 comment)
File src/osmocom/utils.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/43371/comment/c8c32d27_0802f... :
PS1, Line 121: int.from_bytes(packed, byteorder='little')
Just wondering, it should not matter if 0x01 or 0x00 is appended, correct?
ping @biofel@cape.co - would you please address this comment so we can get your patches finally merged? Thanks!
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I4661352e39031dc0041fc7851f675d6083a1035f
Gerrit-Change-Number: 43371
Gerrit-PatchSet: 1
Gerrit-Owner: biocape
biofel@cape.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: biocape
biofel@cape.co
Gerrit-Comment-Date: Fri, 09 Oct 2026 12:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de