Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email ) Change subject: s1gw: derive altsteps from f_ConnHdlr_rx_s1ap_from_{enb,mme}() ...................................................................... Patch Set 1: (2 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849/comment/98b29898_95c2f... : PS1, Line 154: [] as_ConnHdlr_s1ap_from_enb(pdu, tr_pdu) {
Not sure what do you win with this but OK.... The altstep name clearly indicates direction from where the PDU is coming from (from eNB). With the old naming this was less obvious.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849/comment/f9ea8bb8_a47c5... : PS1, Line 187: as_ConnHdlr_s1ap_from_mme Here we eliminate the need to use `S1AP_RecvFrom` and get `S1AP_PDU` directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8637a8abed0f0152abf2dce63ac28aa90f85bdc7 Gerrit-Change-Number: 39849 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 26 Mar 2025 12:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>