falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email ) Change subject: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX ...................................................................... mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX For every call leg handled by OsmoMSC, 2 CRCX commands get sent to the MSC-associated MGW: one for CN side and one for RAN side. Using newly added support in libosmo-mgcp-client, add non-standard X-Side extension parameter to mark which side is which. This indication of RAN vs CN side in CRCX becomes mandatory when OsmoMSC is used with Themyscira Wireless transcoder MGW instead of OsmoMGW (next patch in the series), but even when regular OsmoMGW is used, the non-standard X-Side extension parameter is harmless (ignored by OsmoMGW) while aiding debugging via packet capture, making it clearly visible in pcap which CRCX and which resulting ConnectionId corresponds to which side of the MSC. Depends: I713147d6567fb30de09b2272478d717093d6170e (osmo-mgw.git) Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592 --- M TODO-RELEASE M src/libmsc/rtp_stream.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/01/44001/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 5e970b9..0a167bd 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* libosmo-sigtran >2.3.0 OSMO_SCCP_RETURN_REASON_*, osmo_sccp_return_reason_name() +libosmo-mgcp-client >1.16.0 x_side[] in struct mgcp_conn_peer diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c index 14014c0..b1f4bb0 100644 --- a/src/libmsc/rtp_stream.c +++ b/src/libmsc/rtp_stream.c @@ -315,6 +315,21 @@ .x_osmo_osmux_cid = rtps->remote_osmux_cid, }; + if (verb == MGCP_VERB_CRCX) { + const char *side_name; + switch (rtps->dir) { + case RTP_TO_CN: + side_name = "CN"; + break; + case RTP_TO_RAN: + side_name = "RAN"; + break; + default: + OSMO_ASSERT(0); + } + OSMO_STRLCPY_ARRAY(verb_info.x_side, side_name); + } + verb_info.conn_mode = rtps->crcx_conn_mode; if (rtps->codecs_known) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592 Gerrit-Change-Number: 44001 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org>