17 May
2023
17 May
'23
9:22 p.m.
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716 )
Change subject: fix missing write-back of rnc-id ......................................................................
Patch Set 5:
(1 comment)
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716/comment/471819aa_ed6cd83c PS4, Line 423: vty_out(vty, " rnc-id %u%s", g_hnbgw->config.rnc_id, VTY_NEWLINE);
I think rnc-id sounds more important and hence should probably be put before timers and logging rela […]
oh indeed, didn't notice that, thanks
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ide006379b26949e34371bd316a22c130ea09da82
Gerrit-Change-Number: 32716
Gerrit-PatchSet: 5
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 17 May 2023 19:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment